fix symmetric and unitary

JuliaManifolds · Oct 1, 2024 · 5e79c10 · 5e79c10
1 parent 64dace5
commit 5e79c10
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 15 deletions.
diff --git a/src/manifolds/Symmetric.jl b/src/manifolds/Symmetric.jl
@@ -103,13 +103,7 @@ function get_coordinates_orthonormal!(M::SymmetricMatrices{<:Any,ℝ}, Y, p, X,
     end
     return Y
 end
-function get_coordinates_orthonormal!(
-    M::SymmetricMatrices{<:Any,ℂ},
-    Y,
-    p,
-    X,
-    ::ComplexNumbers,
-)
+function get_coordinates_orthonormal!(M::SymmetricMatrices{<:Any,ℂ}, Y, p, X, ::RealNumbers)
     N = get_parameter(M.size)[1]
     dim = manifold_dimension(M)
     @assert size(Y) == (dim,)
@@ -150,7 +144,7 @@ function get_vector_orthonormal!(M::SymmetricMatrices{<:Any,ℝ}, Y, p, X, ::Rea
     end
     return Y
 end
-function get_vector_orthonormal!(M::SymmetricMatrices{<:Any,ℂ}, Y, p, X, ::ComplexNumbers)
+function get_vector_orthonormal!(M::SymmetricMatrices{<:Any,ℂ}, Y, p, X, ::RealNumbers)
     N = get_parameter(M.size)[1]
     dim = manifold_dimension(M)
     @assert size(X) == (dim,)

diff --git a/src/manifolds/Unitary.jl b/src/manifolds/Unitary.jl
@@ -53,7 +53,7 @@ function get_coordinates_orthonormal(
     ::UnitaryMatrices{TypeParameter{Tuple{1}},ℍ},
     p,
     X::Quaternions.Quaternion,
-    ::QuaternionNumbers,
+    ::RealNumbers,
 )
     return @SVector [X.v1, X.v2, X.v3]
 end
@@ -62,7 +62,7 @@ function get_vector_orthonormal(
     ::UnitaryMatrices{TypeParameter{Tuple{1}},ℍ},
     p::Quaternions.Quaternion,
     c,
-    ::QuaternionNumbers,
+    ::RealNumbers,
 )
     i = firstindex(c)
     return Quaternions.quat(0, c[i], c[i + 1], c[i + 2])

diff --git a/test/manifolds/symmetric.jl b/test/manifolds/symmetric.jl
@@ -77,8 +77,8 @@ include("../header.jl")
                     SchildsLadderTransport(),
                     PoleLadderTransport(),
                 ],
-                basis_types_vecs=(DefaultOrthonormalBasis(ℂ),),
-                basis_types_to_from=(DefaultOrthonormalBasis(ℂ),),
+                basis_types_vecs=(DefaultOrthonormalBasis(ℝ),),
+                basis_types_to_from=(DefaultOrthonormalBasis(ℝ),),
                 is_tangent_atol_multiplier=1,
                 test_inplace=true,
             )

diff --git a/test/manifolds/unitary_matrices.jl b/test/manifolds/unitary_matrices.jl
@@ -144,12 +144,12 @@ end
     @test is_point(M, q)
     @test isapprox(q, sign(pu))
 
-    @test get_coordinates(M, p, Quaternion(0, 1, 2, 3), DefaultOrthonormalBasis(ℍ)) ==
+    @test get_coordinates(M, p, Quaternion(0, 1, 2, 3), DefaultOrthonormalBasis(ℝ)) ==
           SA[1, 2, 3]
-    @test get_vector(M, p, SA[1, 2, 3], DefaultOrthonormalBasis(ℍ)) ==
+    @test get_vector(M, p, SA[1, 2, 3], DefaultOrthonormalBasis(ℝ)) ==
           Quaternion(0, 1, 2, 3)
 
-    @test get_basis(M, p, DefaultOrthonormalBasis(ℍ)).data == [
+    @test get_basis(M, p, DefaultOrthonormalBasis(ℝ)).data == [
         Quaternion(0.0, 1.0, 0.0, 0.0),
         Quaternion(0.0, 0.0, 1.0, 0.0),
         Quaternion(0.0, 0.0, 0.0, 1.0),