make tests more safe.

JuliaManifolds · Oct 20, 2023 · b978606 · b978606
1 parent e673e69
commit b978606
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/ext/ManifoldsTestExt/tests_general.jl b/ext/ManifoldsTestExt/tests_general.jl
@@ -350,14 +350,23 @@ function test_manifold(
             epsx = find_eps(p)
             for inv_retr_method in inverse_retraction_methods
                 X = inverse_retract(M, p, p, inv_retr_method)
-                Y = copy(M, p, X)
-                inverse_retract!(M, Y, p, p, inv_retr_method)
-                for Z in [X, Y]
+                Test.@test isapprox(
+                    M,
+                    p,
+                    zero_vector(M, p),
+                    X;
+                    atol=epsx * retraction_atol_multiplier,
+                    rtol=retraction_atol_multiplier == 0 ?
+                         sqrt(epsx) * retraction_rtol_multiplier : 0,
+                )
+                if (test_inplace && is_mutating)
+                    Y = copy(M, p, X)
+                    inverse_retract!(M, Y, p, p, inv_retr_method)
                     Test.@test isapprox(
                         M,
                         p,
                         zero_vector(M, p),
-                        Z;
+                        Y;
                         atol=epsx * retraction_atol_multiplier,
                         rtol=retraction_atol_multiplier == 0 ?
                              sqrt(epsx) * retraction_rtol_multiplier : 0,