fix CI and bump version

JuliaManifolds · Nov 14, 2023 · baa45a8 · baa45a8
1 parent ae8fe22
commit baa45a8
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.9.7] - 2023-11-14
+
+### Fixed
+
+- Fixed `is_flat` for `CholeskySpace` and `SymmetricPositiveDefinite` with `LogCholeskyMetric` [https://github.com/JuliaManifolds/Manifolds.jl/issues/684](https://github.com/JuliaManifolds/Manifolds.jl/issues/684).
+
 ## [0.9.6] - 2023-11-09
 
 ### Fixed

diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Manifolds"
 uuid = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.9.6"
+version = "0.9.7"
 
 [deps]
 Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"

diff --git a/test/manifolds/cholesky_space.jl b/test/manifolds/cholesky_space.jl
@@ -4,7 +4,7 @@ include("../utils.jl")
     M = Manifolds.CholeskySpace(3)
     @test repr(M) == "CholeskySpace(3)"
 
-    @test !is_flat(M)
+    @test is_flat(M)
 
     types = [Matrix{Float64}]
     TEST_FLOAT32 && push!(types, Matrix{Float32})

diff --git a/test/manifolds/symmetric_positive_definite.jl b/test/manifolds/symmetric_positive_definite.jl
@@ -34,7 +34,11 @@ include("../utils.jl")
         end
         @testset "$(typeof(M))" begin
             @test representation_size(M) == (3, 3)
-            @test !is_flat(M)
+            if M === M3
+                @test is_flat(M)
+            else
+                @test !is_flat(M)
+            end
             for T in types
                 exp_log_atol_multiplier = 8.0
                 if T <: MMatrix{3,3,Float64}