GroupManifold accepts two arguments

JuliaManifolds · Sep 14, 2024 · cce7531 · cce7531
1 parent 11f0a6c
commit cce7531
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/groups/GroupManifold.jl b/src/groups/GroupManifold.jl
@@ -24,6 +24,14 @@ struct GroupManifold{
     vectors::VR
 end
 
+function GroupManifold(
+    M::AbstractManifold{𝔽},
+    op,
+    rep=LeftInvariantRepresentation(),
+) where {𝔽}
+    return GroupManifold{𝔽,typeof(M),typeof(op),typeof(rep)}(M, op, rep)
+end
+
 """
     vector_representation(M::GroupManifold)
 

diff --git a/test/groups/groups_general.jl b/test/groups/groups_general.jl
@@ -138,11 +138,7 @@ using Manifolds:
         @test switch_direction(LeftAction()) === RightAction()
         @test switch_direction(RightAction()) === LeftAction()
 
-        G = GroupManifold(
-            NotImplementedManifold(),
-            NotImplementedOperation(),
-            Manifolds.LeftInvariantRepresentation(),
-        )
+        G = GroupManifold(NotImplementedManifold(), NotImplementedOperation())
         @test Manifolds._action_order(G, 1, 2, LeftForwardAction()) === (1, 2)
         @test Manifolds._action_order(G, 1, 2, RightBackwardAction()) === (2, 1)
     end
@@ -153,11 +149,7 @@ using Manifolds:
     end
 
     @testset "Addition operation" begin
-        G = GroupManifold(
-            NotImplementedManifold(),
-            Manifolds.AdditionOperation(),
-            Manifolds.LeftInvariantRepresentation(),
-        )
+        G = GroupManifold(NotImplementedManifold(), Manifolds.AdditionOperation())
         test_group(
             G,
             [[1.0, 2.0], [3.0, 4.0], [5.0, 6.0]],