Mixinf Hamiltonian with other matrices introduces 120+ ambiguities, l…

…et's not do that.

src/manifolds/Hamiltonian.jl

@@ -29,14 +29,8 @@ function Matrix(A::Hamiltonian)
 end
 
 Base.:*(H::Hamiltonian, K::Hamiltonian) = Hamiltonian(H.value * K.value)
-Base.:*(H::Hamiltonian, A::AbstractMatrix) = H.value * A
-Base.:*(A::AbstractMatrix, K::Hamiltonian) = A * K.value
 Base.:+(H::Hamiltonian, K::Hamiltonian) = Hamiltonian(H.value .+ K.value)
-Base.:+(H::Hamiltonian, A::AbstractMatrix) = H.value .+ A
-Base.:+(A::AbstractMatrix, K::Hamiltonian) = A .+ K.value
 Base.:-(H::Hamiltonian, K::Hamiltonian) = Hamiltonian(H.value .- K.value)
-Base.:-(H::Hamiltonian, A::AbstractMatrix) = H.value .- A
-Base.:-(A::AbstractMatrix, K::Hamiltonian) = A .- K.value
 
 function show(io::IO, A::Hamiltonian)
     return print(io, "Hamiltonian($(A.value))")

src/manifolds/SymplecticStiefel.jl

@@ -110,7 +110,7 @@ Check whether `p` is a valid point on the [`SymplecticStiefel`](@ref),
 ``\mathrm{SpSt}(2n, 2k)`` manifold, that is ``p^{+}p`` is the identity,
 ``(⋅)^+`` denotes the [`symplectic_inverse`](@ref).
 """
-function check_point(M::SymplecticStiefel{<:Any,ℝ}, p::T; kwargs...) where {T}
+function check_point(M::SymplecticStiefel{<:Any,ℝ}, p; kwargs...)
     # Perform check that the matrix lives on the real symplectic manifold:
     if !isapprox(inv(M, p) * p, I; kwargs...)
         return DomainError(

test/ambiguities.jl

@@ -1,3 +1,4 @@
+include("header.jl")
 """
     has_type_in_signature(sig, T::Type)
 
@@ -11,7 +12,7 @@ function has_type_in_signature(sig, T::Type)
 end
 
 @testset "Ambiguities" begin
-    if VERSION.prerelease == () && !Sys.iswindows() && VERSION < v"1.10.0"
+    if VERSION.prerelease == () && !Sys.iswindows() && VERSION < v"1.11.0"
         mbs = Test.detect_ambiguities(ManifoldsBase)
         # Interims solution until we follow what was proposed in
         # https://discourse.julialang.org/t/avoid-ambiguities-with-individual-number-element-identity/62465/2