add segre and warped segre manifold (#755)

* add Segre and warped Segre manifold * added formulas to Segre manifold documentation * Setup docs, fix a few type errors, runs formatter. * Add link to Segre. --------- Co-authored-by: Simon Jacobsson <[email protected]> Co-authored-by: Ronny Bergmann <[email protected]>
JuliaManifolds · Dec 20, 2024 · f03ac74 · f03ac74
1 parent 80541bb
commit f03ac74
Show file tree

Hide file tree

Showing 15 changed files with 1,225 additions and 31 deletions.
diff --git a/.github/workflows/documenter.yml b/.github/workflows/documenter.yml
@@ -17,7 +17,7 @@ jobs:
           version: "1.6.38"
       - uses: julia-actions/setup-julia@latest
         with:
-          version: "1.10"
+          version: "1.11"
       - name: Julia Cache
         uses: julia-actions/cache@v2
       - name: Cache Quarto

diff --git a/.zenodo.json b/.zenodo.json
@@ -31,6 +31,12 @@
             "name": "Weiß, Manuel",
             "type": "ProjectMember"
         },
+        {
+            "affiliation": "KU Leuven",
+            "name": "Jacobsson, Simon",
+            "orcid": "0000-0002-1181-972X",
+            "type": "ProjectMember"
+        },
         {
             "affiliation": "Georg-August-University Göttingen",
             "name": "Klingbiel, Lukas",

diff --git a/NEWS.md b/NEWS.md
@@ -5,10 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.10.9] - unreleased
+## [0.10.9] - 2024-12-20
 
 ### Added
 
+* the `Segre` manifold
+* the `WarpedMetric` for the `Segre`manifold
 * The manifold `HeisenbergMatrices` as the underlying manifold of `HeisenbergGroup`.
 
 ### Changed

diff --git a/_quarto.yml b/_quarto.yml
diff --git a/docs/make.jl b/docs/make.jl
@@ -201,6 +201,7 @@ makedocs(;
                 "Projective space" => "manifolds/projectivespace.md",
                 "Orthogonal and Unitary Matrices" => "manifolds/generalunitary.md",
                 "Rotations" => "manifolds/rotations.md",
+                "Segre" => "manifolds/segre.md",
                 "Shape spaces" => "manifolds/shapespace.md",
                 "Skew-Hermitian matrices" => "manifolds/skewhermitian.md",
                 "Spectrahedron" => "manifolds/spectrahedron.md",

diff --git a/docs/src/manifolds/segre.md b/docs/src/manifolds/segre.md
@@ -0,0 +1,31 @@
+# The Segre manifold
+
+```@docs
+Segre
+```
+
+```@autodocs
+Modules = [Manifolds]
+Pages = ["manifolds/Segre.jl"]
+Order = [:function]
+```
+
+## [A warped metric](@id segre-warped-metric-sec)
+
+```@docs
+WarpedMetric
+```
+
+```@autodocs
+Modules = [Manifolds]
+Pages = ["manifolds/SegreWarpedMetric.jl"]
+Order = [:function]
+```
+
+
+## Literature
+
+```@bibliography
+Pages = ["segre.md"]
+Canonical=false
+```
diff --git a/docs/src/misc/about.md b/docs/src/misc/about.md
@@ -17,6 +17,7 @@
 - [Nick Dewaele](https://github.com/Nikdwal) contributed the [Tucker manifold](../manifolds/tucker.md)
 - [Renée Dornig](https://github.com/r-dornig) contributed the [centered  matrices](../manifolds/centeredmatrices.md) and the [essential manifold](../manifolds/essentialmanifold.md)
 - [David Hong](https://github.com/dahong67) contributed uniform distributions on the Stiefel and Grassmann manifolds.
+- [Simon Jacobsson](https://github.com/sjacobsson) contributed the [Segre manifold](../manifolds/segre.md) including its [warped metric](@ref segre-warped-metric-sec) thereon.
 - [Johannes Voll Kolstø](https://github.com/johannvk) contributed the [symplectic manifold](../manifolds/symplectic.md), the [symplectic Stiefel manifold](../manifolds/symplecticstiefel.md)
 - [Manuel Weiß](https://github.com/manuelweisser) contributed [symmetric matrices](../manifolds/symmetric.md)
 

diff --git a/docs/src/references.bib b/docs/src/references.bib
@@ -478,6 +478,16 @@ @article{HueperMarkinaSilvaLeite:2021
 #
 # J
 # ----------------------------------------------------------------------------------------
+@misc{JacobssonSwijsenVandervekenVannieuwenhoven:2024,
+      title={Warped geometries of Segre-Veronese manifolds}, 
+      author={Simon Jacobsson and Lars Swijsen and Joeri Van der Veken and Nick Vannieuwenhoven},
+      year={2024},
+      eprint={2410.00664},
+      archivePrefix={arXiv},
+      primaryClass={math.NA},
+      url={https://arxiv.org/abs/2410.00664}, 
+}
+
 @article{JourneeBachAbsilSepulchre:2010,
     DOI        = {10.1137/080731359},
     EPRINT     = {0807.4423},
@@ -951,4 +961,4 @@ @article{AastroemPetraSchmitzerSchnoerr:2017
     AUTHOR     = {Freddie Åström and Stefania Petra and Bernhard Schmitzer and Christoph Schnörr},
     TITLE      = {Image Labeling by Assignment},
     JOURNAL    = {Journal of Mathematical Imaging and Vision}
-}
+}
diff --git a/docs/styles/config/vocabularies/Manifolds/accept.txt b/docs/styles/config/vocabularies/Manifolds/accept.txt
@@ -1,6 +1,7 @@
 Grassmann
 [Jj]ulia
 Riemannian
+Segre
 Stiefel
 [sS]ymplectic
 struct
diff --git a/src/Manifolds.jl b/src/Manifolds.jl
@@ -453,6 +453,8 @@ include("manifolds/MultinomialSymmetric.jl")
 include("manifolds/MultinomialSymmetricPositiveDefinite.jl")
 include("manifolds/PositiveNumbers.jl")
 include("manifolds/ProjectiveSpace.jl")
+include("manifolds/Segre.jl")
+include("manifolds/SegreWarpedMetric.jl")
 include("manifolds/SkewHermitian.jl")
 include("manifolds/Spectrahedron.jl")
 include("manifolds/Stiefel.jl")
@@ -660,6 +662,7 @@ export Euclidean,
     ProbabilitySimplex,
     ProjectiveSpace,
     Rotations,
+    Segre,
     SkewHermitianMatrices,
     SkewSymmetricMatrices,
     Spectrahedron,
@@ -738,7 +741,8 @@ export AbstractMetric,
     ProductMetric,
     RealSymplecticMetric,
     RiemannianMetric,
-    StiefelSubmersionMetric
+    StiefelSubmersionMetric,
+    WarpedMetric
 export AbstractAtlas, RetractionAtlas
 # Vector transport types
 export AbstractVectorTransportMethod, ParallelTransport, ProjectionTransport
@@ -807,6 +811,7 @@ export ×,
     christoffel_symbols_first,
     christoffel_symbols_second,
     christoffel_symbols_second_jacobian,
+    connected_by_geodesic,
     convert,
     complex_dot,
     decorated_manifold,