-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typos #728
fix typos #728
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
===========================================
- Coverage 99.58% 42.14% -57.44%
===========================================
Files 114 114
Lines 11230 11111 -119
===========================================
- Hits 11183 4683 -6500
- Misses 47 6428 +6381 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting so many typos and fixing them. 🏅
Thanks! I will check the CI failure, it looks unrelated to changes in this PR. |
The CI failure is just the changelog, we can change/add a note on fixed typos in there on another PR. |
No, there is something wrong with our FiniteDifferences.jl extension. |
I tried fixing it in #729. Making a copy is not ideal but |
please draft a note and post it here |
Sure. There you could just add a line that several typographical errors were fixed. We will add a few points in the next few PRs before we register a new version (and maybe Mateusz newest PR/fix is such a vision as well). So maybe
? |
my draft change to NEWS.md ## [0.9.19] – unreleased
### Changed
- * fixed a few typos in the doc string of the SPD fixed determinant description.
* Updated `Project.toml` compatibility entries.
+ ### Fixed
+
+ * a few typos in the doc string of the SPD fixed determinant description
+ * several other typographical errors throughout the documentation
+
## [0.9.18] – 2024-05-07 |
Looks good. You could also just commit that here and I would comment on the code (probably even with a proposed change). |
@kellertuer MetricManifold.jl NEWS.md performed soft reset |
cf: failed CI / Julia ~1.10.0-0 - test_manifolds - ubuntu-latest (pull_request) owing to this pull's edit of NEWS.md it might be preferable to schedule a NEWS.md entry for whatever fix is decided upon for the cited failed test until after this pull is merged |
No worries, this is unrelated to your changes, it seems DifferentialEquations changed something they thought is nonbreaking but it actually was. This happens every now and then – I think they are just not careful enough. But Mateusz has started the fix already at #729. And sure both PRs together would have a joint entry fpr the version then. Maybe we merge this one shortly before the other so Mateusz can take care of a joint entry :) |
Closes #727