-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe don't split distributions extension #757
Conversation
JuliaFormatter v2 has some serious issues reported so maybe let's keep using v1 for now. |
v2 was even yanked I think, so while I look forward to it, since it does use JuliaSyntax – yes we should wait with that for sure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 123 123
Lines 11438 11438
=======================================
Hits 11025 11025
Misses 413 413 ☔ View full report in Codecov by Sentry. |
I have no idea why the Manopt integration test suddenly fails... should we maybe try a different Julia version on CI? |
I also have no clue why it claims Manifolds is not in the dependencies there. That seems to be unrelated to the PR here? |
It is unrelated, so I will merge this anyway. |
I do not even et all what the error message wants to tell me. And it worked before. So I have no clue what is happening there nor howI should debug a dependency error from within an Extension that is based on the package it reports to be missing?! |
Hopefully it will just resolve itself. |
No description provided.