Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjoint matrix and some jacobians #767

Merged
merged 14 commits into from
Nov 16, 2024
Merged

Conversation

mateuszbaran
Copy link
Member

A generic implementation of adjoint matrix with optimized implementations for selected groups. I've adjusted optimized formulas to match our conventions so it's not exactly the same as in original papers for SE(2) and SE(3).

@mateuszbaran mateuszbaran added the preview docs Add this label if you want to see a PR-preview of the documentation label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (d1d4166) to head (c94a12a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         124      124           
  Lines       11512    11590   +78     
=======================================
+ Hits        11099    11175   +76     
- Misses        413      415    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olivierverdier
Copy link
Contributor

@mateuszbaran
Copy link
Member Author

That could be true but I'm not sure how to use your function to get the result that I want.

@olivierverdier
Copy link
Contributor

If you have a vector $X$ in the Lie algebra, I think that it would be matrix_from_lin_endomorphism(G, Y -> lie_bracket(G, X, Y), DefaultOrthogonalBasis()).

@mateuszbaran
Copy link
Member Author

I'm not sure it's the same adjoint. Anyway, here the primary need is to be able to overload the computation for selected manifolds with optimized code and doing that with matrix_from_lin_endomorphism would be tricky.

@mateuszbaran mateuszbaran changed the title Adjoint matrix Adjoint matrix and some jacobians Nov 15, 2024
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a few small comments.

src/groups/special_euclidean.jl Outdated Show resolved Hide resolved
src/groups/special_euclidean.jl Outdated Show resolved Hide resolved
src/groups/special_euclidean.jl Show resolved Hide resolved
src/groups/special_euclidean.jl Outdated Show resolved Hide resolved
src/groups/special_orthogonal.jl Outdated Show resolved Hide resolved
@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Nov 15, 2024
@mateuszbaran mateuszbaran merged commit 47ec4cd into master Nov 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants