-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjoint matrix and some jacobians #767
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 124 124
Lines 11512 11590 +78
=======================================
+ Hits 11099 11175 +76
- Misses 413 415 +2 ☔ View full report in Codecov by Sentry. |
I think this is what I already implemented here (in a more general setting): https://olivierverdier.github.io/ManifoldGroupUtils.jl/stable/#ManifoldGroupUtils.matrix_from_lin_endomorphism-Tuple{Any,%20Any,%20ManifoldsBase.AbstractBasis} |
That could be true but I'm not sure how to use your function to get the result that I want. |
If you have a vector |
I'm not sure it's the same adjoint. Anyway, here the primary need is to be able to overload the computation for selected manifolds with optimized code and doing that with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a few small comments.
Co-authored-by: Ronny Bergmann <[email protected]>
A generic implementation of adjoint matrix with optimized implementations for selected groups. I've adjusted optimized formulas to match our conventions so it's not exactly the same as in original papers for SE(2) and SE(3).