Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some type annotations in GeneralUnitaryMatrices get_vector #770

Merged
merged 4 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/documenter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
- uses: actions/checkout@v4
- uses: quarto-dev/quarto-actions/setup@v2
with:
version: "1.4.551"
version: "1.6.38"
- uses: julia-actions/setup-julia@latest
with:
version: "1"
version: "1.10"
- name: Julia Cache
uses: julia-actions/cache@v2
- name: Cache Quarto
Expand Down
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.10.8] – unreleased
## [0.10.8] – 2024-11-27

### Changed

* Some methods related to `get_vector` for `GeneralUnitaryMatrices` now have `AbstractVector` upper bound for coefficients.
* Minimum Julia version is now 1.10 (the LTS which replaced 1.6)

## [0.10.7] – 2024-11-16
Expand Down
8 changes: 4 additions & 4 deletions src/manifolds/GeneralUnitaryMatrices.jl
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ function get_vector_orthogonal!(
::GeneralUnitaryMatrices{TypeParameter{Tuple{1}},ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
N::RealNumbers,
)
return X .= 0
Expand All @@ -518,7 +518,7 @@ function get_vector_orthogonal!(
M::GeneralUnitaryMatrices{TypeParameter{Tuple{2}},ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
N::RealNumbers,
)
return get_vector_orthogonal!(M, X, p, Xⁱ[1], N)
Expand All @@ -543,7 +543,7 @@ function get_vector_orthogonal!(
M::GeneralUnitaryMatrices{TypeParameter{Tuple{n}},ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
::RealNumbers,
) where {n}
@assert size(X) == (n, n)
Expand Down Expand Up @@ -622,7 +622,7 @@ function get_vector_orthonormal!(
M::GeneralUnitaryMatrices{<:Any,ℝ},
X,
p,
Xⁱ,
Xⁱ::AbstractVector,
N::RealNumbers,
)
T = Base.promote_eltype(p, X)
Expand Down
Loading