Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heisenberg matrices #775

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Heisenberg matrices #775

merged 3 commits into from
Dec 16, 2024

Conversation

mateuszbaran
Copy link
Member

So that we can add HeisenbergGroup to LieGroups.jl.

@mateuszbaran mateuszbaran added Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation labels Dec 16, 2024
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments

docs/src/manifolds/heisenbergmatrices.md Outdated Show resolved Hide resolved
src/manifolds/HeisenbergMatrices.jl Outdated Show resolved Hide resolved
src/manifolds/HeisenbergMatrices.jl Show resolved Hide resolved
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (b62ce19) to head (78643b0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   96.36%   96.37%   +0.01%     
==========================================
  Files         124      125       +1     
  Lines       11582    11625      +43     
==========================================
+ Hits        11161    11204      +43     
  Misses        421      421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszbaran mateuszbaran merged commit c140918 into master Dec 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants