Fixes #342 (#343)

Changelog.md

@@ -5,6 +5,12 @@ All notable Changes to the Julia package `Manopt.jl` will be documented in this
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.47] January 6, 2024
+
+### Fixed
+
+* fixed a bug, where the retraction set in `check_Hessian` was not passed on to the optional inner `check_gradient` call, which could lead to unwanted side effects, see [#342](https://github.com/JuliaManifolds/Manopt.jl/issues/342).
+
 ## [0.4.46] January 1, 2024
 
 ### Changed

Project.toml

@@ -1,7 +1,7 @@
 name = "Manopt"
 uuid = "0fc0a36d-df90-57f3-8f93-d78a9fc72bb5"
 authors = ["Ronny Bergmann <[email protected]>"]
-version = "0.4.46"
+version = "0.4.47"
 
 [deps]
 ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"

src/helpers/checks.jl

@@ -259,8 +259,11 @@ no plot will be generated.
 * `window` – (`nothing`) specify window sizes within the `log_range` that are used for the slope estimation.
   the default is, to use all window sizes `2:N`.
 
-The `kwargs...` are also passed down to the `check_vector` call, such that tolerances can
+The `kwargs...` are also passed down to the `check_vector` and the `check_gradient` call, such that tolerances can
 easily be set.
+
+While we do pass on `check_vector` to the inner gradient check as well as the `retraction_method`,
+the gradient check is meant to be a sanity check, so it does not throw an error nor produce a plot itself.
 """
 function check_Hessian(
     M::AbstractManifold,
@@ -303,8 +306,10 @@ function check_Hessian(
             gradient=gradient,
             throw_error=throw_error,
             io=io,
+            check_vector=check_vector,
             atol=atol,
             rtol=rtol,
+            retraction_method=retraction_method,
             kwargs...,
         )
             return false