add the remaining tests.

JuliaManifolds · Dec 30, 2024 · 8dc437f · 8dc437f
1 parent 2261efb
commit 8dc437f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/plans/vectorial_plan.jl b/src/plans/vectorial_plan.jl
@@ -1164,11 +1164,7 @@ function get_value!(
     i=:,
 )
     c = vgf.value!!(M, p)
-    if isa(c, Number)
-        V .= c
-    else
-        V .= c[i]
-    end
+    V .= c[i]
     return V
 end
 

diff --git a/test/plans/test_vectorial_plan.jl b/test/plans/test_vectorial_plan.jl
@@ -57,6 +57,8 @@ using Manopt: get_value, get_value_function, get_gradient_function
         jacobian_type=CoordinateVectorialType(DefaultOrthonormalBasis()),
         evaluation=InplaceEvaluation(),
     )
+    @test Manopt.get_jacobian_basis(vgf_ji) == vgf_ji.jacobian_type.basis
+    @test Manopt.get_jacobian_basis(vgf_vi) == DefaultOrthonormalBasis()
     p = [1.0, 2.0, 3.0]
     c = [0.0, -3.0]
     gg = [[1.0, 0.0, 0.0], [0.0, -1.0, 0.0]]