Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jacobian_tangent_basis to docstring #304

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Oct 12, 2023

I was confused when reading

then the keyword jacobian_tangent_basis below is ignored

since there was no such keyword below.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #304 (d16c731) into master (c4bc49d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          77       77           
  Lines        7087     7087           
=======================================
  Hits         7069     7069           
  Misses         18       18           
Files Coverage Δ
src/solvers/LevenbergMarquardt.jl 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can include this in the next release.

@kellertuer kellertuer merged commit 81b7328 into JuliaManifolds:master Oct 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants