-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes from benchmark #341
Fixes from benchmark #341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 99.79% 99.60% -0.19%
==========================================
Files 69 69
Lines 6361 6372 +11
==========================================
- Hits 6348 6347 -1
- Misses 13 25 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure where we lose the subsolver gradient access test but the Wolfe-conidtion one is one that is definelty unrelated to the changes here. If you have a moment, taking a look would be great but otherwise this is also fine.
I think we can leave that coverage issue for later. |
Since the benchmark in #339 is not ready yet, I've extracted the bugfixes to a separate branch.