Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from benchmark #341

Merged
merged 18 commits into from
Jan 1, 2024
Merged

Fixes from benchmark #341

merged 18 commits into from
Jan 1, 2024

Conversation

mateuszbaran
Copy link
Member

Since the benchmark in #339 is not ready yet, I've extracted the bugfixes to a separate branch.

@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Jan 1, 2024
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da84054) 99.79% compared to head (eabea17) 99.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   99.79%   99.60%   -0.19%     
==========================================
  Files          69       69              
  Lines        6361     6372      +11     
==========================================
- Hits         6348     6347       -1     
- Misses         13       25      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Changelog.md Outdated Show resolved Hide resolved
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure where we lose the subsolver gradient access test but the Wolfe-conidtion one is one that is definelty unrelated to the changes here. If you have a moment, taking a look would be great but otherwise this is also fine.

@mateuszbaran
Copy link
Member Author

I think we can leave that coverage issue for later.

@mateuszbaran mateuszbaran merged commit a24c869 into master Jan 1, 2024
14 of 15 checks passed
@kellertuer kellertuer deleted the mbaran/fixes-from-benchmark branch May 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants