-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate more precisely bewteen swarm and iterate in PSO more stricly #344
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 99.60% 99.62% +0.01%
==========================================
Files 69 69
Lines 6372 6380 +8
==========================================
+ Hits 6347 6356 +9
+ Misses 25 24 -1 ☔ View full report in Codecov by Sentry. |
For a generic interface maybe |
That sounds like a very good idea, to call that generic name |
We noticed an inconsistency yesterday, where (probably for historic reasons) the swarm was sometimes returned when calling
get_iterate
on theParticleSwarmState
– probably since it made a few things easer.This PR fixes that and introduces
:Swarm
to access the swarm in general within the (much newer than PSO)get_manopt_parameter
and updates its occurrences accordingly.Furthermore
get_manopt_parameter
is now as tolerant asset_manopt_parameter!
and returns nothing (but does not error) if a state/problem/... does not have a certain parameter.