-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework presentation of keywords #393
Conversation
… to specify defaults.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 99.78% 99.76% -0.02%
==========================================
Files 76 77 +1
Lines 8226 8256 +30
==========================================
+ Hits 8208 8237 +29
- Misses 18 19 +1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # Changelog.md
# Conflicts: # Changelog.md
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I think I found a good format by now and with the snippets we also avoid “stringduplication” – that is for example the “first parameter is a manifold” text will soon be the same in all doc strings. |
…nifolds/Manopt.jl into kellertuer/modularize-docstrings # Conflicts: # src/plans/docstring_snippets.jl
I think I have converged to a nice new format, and with a bit of rewriting how the doc string is defined, this allows to reuse parts as well – for example prominent keywords like Format
is nice, since the Now that this is clear, this PR is really just a large work to check all doc strings and reform them. But the benefit is, that this reduces a lot of duplication in the strings as well, since common tens are now defined in Still a bit of work to do, where I will try to work on a doc string every day. |
# Conflicts: # Changelog.md # src/plans/augmented_lagrangian_plan.jl # src/plans/constrained_plan.jl # src/plans/stepsize.jl # src/solvers/FrankWolfe.jl # src/solvers/adaptive_regularization_with_cubics.jl # src/solvers/augmented_Lagrangian_method.jl # src/solvers/convex_bundle_method.jl # src/solvers/difference-of-convex-proximal-point.jl
# Conflicts: # Project.toml
So now this should be good to go. Not sure it is worth its own version, since I will not activate |
Since this is really just involving doc string rewrites, I will merge this now and include it in the next release (the other PR still open). It will hence already reside on master for a while then (without a new version). |
This is heavily WIP (just had a bit on time on the train with not so much concentration).
This aims to
🛣️ Roadmap
plans/
solvers/
Frank_Wolfe_method
and its stategradient_descent
and its state`:(\s+)\(`(.*)`\)
to=$2`:
(maybe with a newline)`:(\s+)\([`(.*)`\)`
(keyword with linking examplesdefault_retraction_method
default_inverse_retraction_method
zero_vector
rand
at_iteration
field should be unifiedk
for iterationsI
for inequality constraintsg_i
j
for equality constraintsh_j
get_gradient
get_cost
get_iterate
:WhenActive
is broken in https://manoptjl.org/stable/tutorials/HowToDebug/#Subsolver-debug