Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly improves performance of interior point Newton method. Together with some light improvements to ManifoldsBase, I got from 9ms to below 3ms on the problem from the test suite. The two biggest issues were:
Y[N, 1]
is really slow. I recommend using things likeY1, Y2 = submanifold_components(N, Y)
in performance-sensitive code. Maybe it would be possible to speed upY[N, 1]
but it would require tinkering with compiler heuristics which is quite difficult and depends on the version of Julia.Not that many potential gains remain as those 3ms are dominated by calls to Hessian and gradient of
g
.