Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@dec_str macro #74

Merged
merged 1 commit into from
Oct 25, 2024
Merged

@dec_str macro #74

merged 1 commit into from
Oct 25, 2024

Conversation

barucden
Copy link
Collaborator

Fixes #26:

julia> dec"1_000.000_001"
1000.000001

Needs #71 to be merged first.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (595edb4) to head (983b036).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   97.81%   98.03%   +0.22%     
==========================================
  Files          10       10              
  Lines         183      204      +21     
==========================================
+ Hits          179      200      +21     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member

@barucden You should proceed with merging your PRs!

@barucden
Copy link
Collaborator Author

I will do so over the weekend

Fixes JuliaMath#26:
```julia
julia> dec"10_000.000_000_1"
10000.0000001
```
@barucden barucden merged commit 29a80b4 into JuliaMath:master Oct 25, 2024
7 checks passed
@barucden barucden deleted the decstr branch October 25, 2024 18:56
@ViralBShah
Copy link
Member

Please feel free to tag a new version of the package whenever convenient. Great to see the improvements!

@barucden
Copy link
Collaborator Author

There are still issues that I would like to tackle before releasing a new version. I don't intend to implement any new features, but I would like to make the currently provided operations sound and stable, supported by extensive test-suite and documentation. To this end, I plan to

This will take me one or two weeks more, but I will gain much more confidence in the package and its correctness (xref #56). If it's okay with you, I would postpone releasing a new version until then.

@ViralBShah
Copy link
Member

Of course! I just meant to say that please feel free to tag a release whenever convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse underscores
2 participants