[WIP] Move from implicitly mapped measures and kernels to data tagged as mapped #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likelihoods can be built from callables as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 56.32% 56.47% +0.15%
==========================================
Files 44 44
Lines 1321 1351 +30
==========================================
+ Hits 744 763 +19
- Misses 577 588 +11 ☔ View full report in Codecov by Sentry. |
|
cscherrer
reviewed
Nov 9, 2024
Comment on lines
+22
to
+23
| function strict_logdensityof(μ::Half, x) | ||
| ld = strict_logdensityof(unhalf(μ), x) - loghalf |
There was a problem hiding this comment.
I need to have another look at this - should it just be logdensity_def?
If we need to merge before this is resolved, let's add a #TODO comment
There was a problem hiding this comment.
No, this is part of specializing logdensityof (e242314) to avoid the multi-step logdensity_def machinery if users don't need logdensity_rel (until we revamp that machinery to make it more type-stable and Zygote-friendly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.