Fix 5-argument boxdot! (#21)

* Fix 5-argument `boxdot!` * Fix test
JuliaMath · Oct 24, 2024 · ca2e4ca · ca2e4ca
1 parent f8bc400
commit ca2e4ca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/TensorCore.jl b/src/TensorCore.jl
@@ -278,7 +278,7 @@ else
 
     # For boxdot!, only where mul! behaves differently:
     boxdot!(Y::AbstractArray, A::AbstractArray, B::AdjOrTransAbsVec,
-        α::Number=true, β::Number=false) = boxdot!(Y, A, vec(B))
+        α::Number=true, β::Number=false) = boxdot!(Y, A, vec(B), α, β)
 
 end
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -188,7 +188,7 @@ end
     d = [3im, 4-5im]
 
     @test A ⊡ B == A * B
-    @test A ⊡ c == A ⊡ c
+    @test A ⊡ c == A * c
     @test c ⊡ A == vec(transpose(c) * A)
     @test c ⊡ d == sum(c .* d)
 
@@ -268,6 +268,8 @@ end
     if VERSION >= v"1.3"
         @test boxdot!(similar(c), A, c, 100) == A * c * 100
         @test boxdot!(copy(c), B, d, 100, -5) == B * d * 100 .- 5 .* c
+        @test boxdot!(similar(c), A, c', 100) == A * conj(c) * 100
+        @test boxdot!(copy(c), B, d', 100, -5) == B * conj(d) * 100 .- 5 .* c
     end
 
     @test boxdot!(similar(c), A, c') == A * conj(c)