Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typos. #557

Merged
merged 5 commits into from
Jul 22, 2024
Merged

fixed typos. #557

merged 5 commits into from
Jul 22, 2024

Conversation

MaderDash
Copy link
Contributor

This should address the typos mentioned in issue #554. #554

zsunberg
zsunberg requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@zsunberg zsunberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaderDash ! this is really helpful, but it looks like a bunch of new files were added by mistake (i.e. everything in the .history folder). Can you remove those?

@MaderDash
Copy link
Contributor Author

Not a problem, please see if this will correct it.

@dylan-asmar
Copy link
Member

The changes look good to me. Since the PR is not from the JuliaPOMDP/POMDPs.jl repo, it didn't generate a preview for the docs. However, I think the issue with the linter only showing the boolean remains (this section). I think we can add a hidden nothing expression to have it return the stdout stream in accordance with the @example documentation.

zsunberg
zsunberg approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@zsunberg zsunberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the extra files. LGTM whenever @dylan-asmar is ready

@zsunberg
Copy link
Member

@dylan-asmar can you merge this when you're ready?

@dylan-asmar dylan-asmar merged commit 4d0b542 into JuliaPOMDP:master Jul 22, 2024
7 checks passed
@dylan-asmar dylan-asmar mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsunberg zsunberg zsunberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaderDash @dylan-asmar @zsunberg