Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore LDAP support #10021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxfadson
Copy link
Contributor

Hi!

How about restoring LDAP support in libcurl_jll? Without it, working with LDAP servers in LibCURL is not possible.

To ensure support, I added the OpenLDAPClient dependency, which provides the necessary headers.

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curl is a Julia dependency and adding dependencies to it has a cost. Someone tried to add kerberos in the past but we had to revert it quickly because everything broke down.

Furthermore, curl is part of a major update in Julia to move openssl and on top of everything I said above I'm strongly against making major changes to the package.

@maxfadson
Copy link
Contributor Author

@giordano what do you think about creating a separate package? For example, libcurl2_jll or another name, but without tying it to Julia’s core. This way, it could be modified and used as the foundation for an improved LibCURL.jl package (perhaps named LibCURL2.jl, for instance).

@giordano
Copy link
Member

You can only load a single shared library with a specific soname. That's a limitation of how dynamic libraries work (and no, before someone suggests it, a platform-specific solution like dlmopen isn't viable, since it won't work anyway on all the other platforms).

@maxfadson
Copy link
Contributor Author

I may have confused you with the way I phrased my question. What I meant was this: do we have the right to create a second binary build named libcurl2_jll in Yggdrasil? The idea is to allow us to use any functionality of the libcurl C library without conflicting with the current libcurl_jll used by the core.
I’m doing this locally, and it works perfectly.

@maxfadson
Copy link
Contributor Author

maxfadson commented Dec 16, 2024

I think it’s better to move the discussion to Slack :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants