Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactant : v0.33 #10159

Merged
merged 11 commits into from
Dec 28, 2024
Merged

Reactant : v0.33 #10159

merged 11 commits into from
Dec 28, 2024

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Dec 27, 2024

No description provided.

@wsmoses wsmoses enabled auto-merge (squash) December 27, 2024 20:24
@wsmoses
Copy link
Contributor Author

wsmoses commented Dec 28, 2024

@giordano I'm getting

ERROR: could not load library "/cache/build/yggy-amdci7-8/julialang/yggdrasil/R/Reactant/build/x86_64-linux-gnu-cxx11-gpu+none-mode+opt/CtEeFboB/x86_64-linux-gnu-libgfortran5-cxx11-gpu+none-mode+opt/destdir/lib/libReactantExtra.so"
--
  | /cache/julia-buildkite-plugin/julia_installs/bin/linux/x64/1.7/julia-1.7-latest-linux-x86_64/bin/../lib/julia/libstdc++.so.6: version `GLIBCXX_3.4.30' not found (required by /cache/build/yggy-amdci7-8/julialang/yggdrasil/R/Reactant/build/x86_64-linux-gnu-cxx11-gpu+none-mode+opt/CtEeFboB/x86_64-linux-gnu-libgfortran5-cxx11-gpu+none-mode+opt/destdir/lib/libReactantExtra.so)
  | ┌ Warning: lib/libReactantExtra.so cannot be dlopen()'ed
  | └ @ BinaryBuilder.Auditor /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilder/CSwfJ/src/Auditor.jl:173

I'm a bit confused here (but indeed perhaps this is due to using a newer gcc in this bump, which is required for various flags).

giordano
giordano reviewed Dec 28, 2024
View reviewed changes
R/Reactant/build_tarballs.jl Outdated Show resolved Hide resolved
R/Reactant/build_tarballs.jl Outdated Show resolved Hide resolved
R/Reactant/build_tarballs.jl Outdated Show resolved Hide resolved
giordano
giordano reviewed Dec 28, 2024
View reviewed changes
R/Reactant/build_tarballs.jl
preferred_gcc_version=v"10", preferred_llvm_version=v"18", julia_compat="1.6",
augment_platform_block, lazy_artifacts=true)
preferred_gcc_version=build.preferred_gcc_version, preferred_llvm_version=v"18", julia_compat="1.10",
# We use GCC 13, so we can't dlopen the library during audit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realised I meant to write "because we can't..." but let's not fix this now, it'll take forever to finish the build otherwise 🥲

@wsmoses wsmoses merged commit 4608d95 into master Dec 28, 2024
9 checks passed
@wsmoses wsmoses deleted the wsmoses-patch-1 branch December 28, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsmoses @giordano