Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCIP_PaPILO] up bugfix release #5637

Merged
merged 6 commits into from
Oct 7, 2022

Conversation

matbesancon
Copy link
Contributor

No description provided.

@@ -58,7 +59,7 @@ dependencies = [
Dependency(PackageSpec(name="Bzip2_jll", uuid="6e34b625-4abd-537c-b88f-471c36dfa7a0"); compat="1.0.8"),
Dependency(PackageSpec(name="CompilerSupportLibraries_jll", uuid="e66e0078-7015-5450-92f7-15fbd957f2ae")),
Dependency(PackageSpec(name="GMP_jll", uuid="781609d7-10c4-51f6-84f2-b8444358ff6d"), v"6.2.0"),
Dependency(PackageSpec(name="Ipopt_jll", uuid="9cc047cb-c261-5740-88fc-0cf96f7bdcc7"), v"300.1400.400"),
Dependency(PackageSpec(name="Ipopt_jll", uuid="9cc047cb-c261-5740-88fc-0cf96f7bdcc7"), "300.1400.403"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v should have stayed there, but I think these should all use appropriate compat instead: #5630 (comment)

@@ -53,12 +54,12 @@ products = [
]

dependencies = [
Dependency(PackageSpec(name="bliss_jll", uuid="508c9074-7a14-5c94-9582-3d4bc1871065"), v"0.77.0"),
Dependency(PackageSpec(name="boost_jll", uuid="28df3c45-c428-5900-9ff8-a3135698ca75"); compat="=1.76.0"),
Dependency(PackageSpec(name="bliss_jll", uuid="508c9074-7a14-5c94-9582-3d4bc1871065"), compat="=0.77.0"),
Copy link
Member

@giordano giordano Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, the message I linked suggested to use = compat only for boost, because they break ABI in every single version, but that's not the case for BLIS and most of the other packages below, as far as I know (but I also don't know all packages out there). But below you do have boost, for that one you do need = 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bliss has had breaking changes all over the place and we don't need the bleeding edge in there so 077 forced seems wise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, didn't know (or remember) that about blis

@giordano giordano merged commit af6fa02 into JuliaPackaging:master Oct 7, 2022
@matbesancon matbesancon deleted the scip-papilo-up branch October 7, 2022 15:27
@matbesancon
Copy link
Contributor Author

thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants