Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPA] add methods to sdpawrap.cpp #6609

Merged
merged 7 commits into from
Aug 9, 2023
Merged

Conversation

odow
Copy link
Contributor

@odow odow commented Apr 18, 2023

I don't really understand what I'm doing, but this looks correct to me.

x-ref jump-dev/SDPA.jl#49

cc @blegat

@odow
Copy link
Contributor Author

odow commented Apr 19, 2023

I don't understand the compilation failures with the (g|s)etDisplay methods: https://buildkite.com/julialang/yggdrasil/builds/2415#01879757-da46-48be-95fa-15f9f98e69ec

error: invalid use of incomplete type ‘struct _IO_FILE’

Do we need to handle FILE* arguments differently somewhere? The headers for the methods are:

void setDisplay(FILE* Display  = stdout);
FILE* getDisplay();

@giordano
Copy link
Member

I don't have much time to look into this, but https://www.openwall.com/lists/musl/2021/10/06/4 is likely relevant.

@odow
Copy link
Contributor Author

odow commented May 15, 2023

@blegat do you want to take a look at this?

@blegat
Copy link
Contributor

blegat commented Jun 27, 2023

Maybe we can merge with getDisplay/setDisplay for now ?

@ViralBShah
Copy link
Member

Should we merge?

@blegat
Copy link
Contributor

blegat commented Aug 9, 2023

No objection from me

@ViralBShah ViralBShah merged commit 519babb into JuliaPackaging:master Aug 9, 2023
@odow odow deleted the patch-2 branch August 11, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants