Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New recipe: catchaMouse16-v0.1.0 #9151
New recipe: catchaMouse16-v0.1.0 #9151
Changes from 13 commits
af764e2
0f2f6a2
881a1a5
a781228
f450b21
08a2fd0
7a4e01b
de4a56e
46efde0
e580151
b7b7bfc
36bf85d
c8250ee
3446673
2179afd
41b1456
f2d9cbb
7897772
069f8c3
b3b5abd
4deeb30
9fc6681
14ff2cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do https://github.com/DynamicsAndNeuralSystems/catchaMouse16/blob/56ad41b669a750df3be60d008010c8a84a5cf4bd/C/Makefile#L18 instead of listing the files manually? This isn't very sustainable if the source code upstream changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking order is important, see for example https://wiki.gentoo.org/wiki/Project:Quality_Assurance/As-needed#Importance_of_linking_order (this may fix the issue on Windows):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.