Changed protoc to build v3.16.0 #9794
Draft
+30
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stemann
force-pushed
the
feature/protoc_3.16.0
branch
from
a1e92c2 to
6c051e9
Compare
Used by ONNX v1.11.0 (and in turn, Torch v1.12.1). Removed notes about protobuf version numbers, cf. JuliaPackaging#9796. No libabsl or libutf8 products produced for this version.
stemann
force-pushed
the
feature/protoc_3.16.0
branch
from
6c051e9 to
0f16d99
Compare
Compiled as position independent code, cf. https://github.com/onnx/onnx/blob/v1.11.0/README.md#linux
stemann
commented
Nov 17, 2024
| @@ -34,18 +19,35 @@ cd $WORKSPACE/srcdir/protobuf | |||
| sed -i -e 's!set(CMAKE_C_COMPILER.*!set(CMAKE_C_COMPILER '${WORKSPACE}/srcdir/files/ccsafe')!' ${CMAKE_TARGET_TOOLCHAIN} | |||
| sed -i -e 's!set(CMAKE_CXX_COMPILER.*!set(CMAKE_CXX_COMPILER '${WORKSPACE}/srcdir/files/c++safe')!' ${CMAKE_TARGET_TOOLCHAIN} | |||
|
|
|||
| git submodule update --init --recursive | |||
| cmake -B build -G Ninja \ | |||
| # Build static libraries | |||
There was a problem hiding this comment.
Probably better to split package into separate lib, lib-static and protoc packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed protoc to build v3.16.0
Used by ONNX v1.11.0 (and in turn, Torch v1.12.1).
One could consider splitting static libraries (and dynamic libraries) into separate JLL's, cf. #9796.