[Powsybl] Support aarch64 macos build for powsybl.jl #9897
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bertrand Rix <[email protected]>
obrix
changed the title
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
giordano
reviewed
Nov 29, 2024
P/Powsybl/build_tarballs.jl
Outdated
| @@ -70,7 +73,7 @@ install_license $WORKSPACE/srcdir/powsybl.jl/LICENSE.md | |||
| include("../../L/libjulia/common.jl") | |||
| platforms = vcat(libjulia_platforms.(julia_versions)...) | |||
|
|
|||
| filter!(p -> arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos"), platforms) | |||
| filter!(p -> arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos") || arch(p) == "aarch64" && occursin(os(p), "macos"), platforms) | |||
There was a problem hiding this comment.
Suggested change
| filter!(p -> arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos") || arch(p) == "aarch64" && occursin(os(p), "macos"), platforms) | |
| filter!(p -> arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos") || arch(p) == "aarch64" && Sys.isapple(p), platforms) |
I think you're missing some parentheses to correctly group the conditions?
There was a problem hiding this comment.
Thanks for isapple. For parenthesis I think it is okay logically ? A && B || C && D should be evaluated as ( x86_64 && 3os ) || (aarch64 && macos)
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
imciner2
reviewed
Dec 27, 2024
| @@ -70,7 +73,7 @@ install_license $WORKSPACE/srcdir/powsybl.jl/LICENSE.md | |||
| include("../../L/libjulia/common.jl") | |||
| platforms = vcat(libjulia_platforms.(julia_versions)...) | |||
|
|
|||
| filter!(p -> arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos"), platforms) | |||
| filter!(p -> arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos") || arch(p) == "aarch64" && Sys.isapple(p), platforms) | |||
There was a problem hiding this comment.
Suggested change
| filter!(p -> arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos") || arch(p) == "aarch64" && Sys.isapple(p), platforms) | |
| # Only build for x86_64 platforms and Apple aarch64 | |
| filter!(p -> (arch(p) == "x86_64" && os(p) ∈ ("windows", "linux", "macos")) || (arch(p) == "aarch64" && Sys.isapple(p)), platforms) |
For clarity, I think this is what you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support aarch64 macos build for powsybl.jl