Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @df support string column names #563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ron-wolf
Copy link

Fixes #562. Add a special case to add_sym! to convert an AbstractString column name to a Symbol before adding it.

The old behavior would iterate over the string and try to add each character as a column name. This produced a stack overflow, since add_sym! had no special case for Char, resulting in indefinite recursion.

Fixes JuliaPlots#562. Add a special case to `add_sym!` to convert an `AbstractString` column name to a `Symbol` before adding it.

The old behavior would iterate over the string and try to add each character as a column name. This produced a stack overflow, since `add_sym!` had no special case for `Char`, resulting in indefinite recursion.
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.44%. Comparing base (bb65b7c) to head (8eaf308).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/df.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #563      +/-   ##
==========================================
- Coverage   26.52%   26.44%   -0.09%     
==========================================
  Files          20       20              
  Lines        1248     1248              
==========================================
- Hits          331      330       -1     
- Misses        917      918       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ron-wolf
Copy link
Author

ron-wolf commented Dec 7, 2024

Merged via JuliaPlots/Plots.jl#5033.

@ron-wolf ron-wolf closed this Dec 7, 2024
@ron-wolf ron-wolf deleted the patch-1 branch December 7, 2024 16:04
@BeastyBlacksmith
Copy link
Member

I mean, if you want it pre 2.0 it should be merged here as well

@ron-wolf ron-wolf restored the patch-1 branch December 22, 2024 12:21
@ron-wolf
Copy link
Author

@BeastyBlacksmith Oh? Didn’t know this repo was still in use (considering the README). I’ll bring it back then.

@ron-wolf ron-wolf reopened this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@df: Passing column name as string overflows stack
3 participants