Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise tensorial form #12

Merged
merged 9 commits into from
Jul 24, 2018
Merged

Revise tensorial form #12

merged 9 commits into from
Jul 24, 2018

Conversation

mforets
Copy link
Member

@mforets mforets commented Jul 23, 2018

@mforets mforets changed the title Add another generate_tensor_form method Revise tensorial_form Jul 23, 2018
@mforets mforets requested a review from roccaa July 23, 2018 23:00
@mforets mforets changed the title Revise tensorial_form Revise tensorial form Jul 23, 2018
@roccaa
Copy link
Collaborator

roccaa commented Jul 24, 2018

What does this checks failing means ? Is it critical ?

Copy link
Collaborator

@roccaa roccaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok for me. I will run this on my laptop around 17h and accept it.

@mforets
Copy link
Member Author

mforets commented Jul 24, 2018

What does this checks failing means ? Is it critical ?

Yes, we (at least try to) solve the failing checks before merging. To see what is going on, see that there are two rows,

  • continuous-integration/travis-ci/pr — The Travis CI build failed this tests the PR after merging
  • continuous-integration/travis-ci/push — The Travis CI build failed this tests only this branch mforets/tensor_nloops

on the box "All checks have failed" if i click on "Details" i see the build jobs, then you click on one of the failing jobs and there is a the full job log in a terminal. The problem seems to be with my choice of version for the dependency RecursiveArrayTools,

27.06s$ julia --color=yes -e "if VERSION < v\"0.7.0-DEV.5183\" || (!isfile(\"Project.toml\") && !isfile(\"JuliaProject.toml\")); Pkg.clone(pwd()); end"
INFO: Initializing package repository /home/travis/.julia/v0.6
INFO: Cloning METADATA from https://github.com/JuliaLang/METADATA.jl
INFO: Cloning BernsteinExpansions from /home/travis/build/JuliaReach/BernsteinExpansions.jl
INFO: Computing changes...
ERROR: fixed packages introduce conflicting requirements for RecursiveArrayTools: 
         BernsteinExpansions requires versions [0.17.0,∞) [none of the available versions can satisfy this requirement]
       available versions are 0.0.1, 0.0.2, 0.0.3, 0.1.0, 0.1.1, 0.1.2, 0.2.0, 0.3.0, 0.4.0, 0.4.1, 0.5.0, 0.6.0, 0.6.1, 0.7.0, 0.7.1, 0.8.0, 0.9.0, 0.10.0, 0.10.1, 0.11.0, 0.11.1, 0.11.2, 0.12.0, 0.12.1, 0.12.2, 0.12.3, 0.12.4, 0.13.0, 0.13.1, 0.14.0, 0.14.1, 0.14.3, 0.14.4, 0.14.5, 0.14.6 and 0.15.0

For now let's remove the version number and let it choose the one it fits for each julia version automatically.

@mforets
Copy link
Member Author

mforets commented Jul 24, 2018

It seems ok for me.

Thanks

@mforets mforets merged commit d880c74 into master Jul 24, 2018
@mforets mforets deleted the mforets/tensor_nloops branch July 24, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants