Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doctest to [email protected] #3538

Closed
wants to merge 1 commit into from
Closed

Update doctest to [email protected] #3538

wants to merge 1 commit into from

Conversation

schillic
Copy link
Member

@schillic schillic commented Jun 26, 2024

This fixes the recent failure of the documentation build. It was caused by a new Symbolics release (v5.31.0), which changes the order of arguments.

Actually, I am not sure we should just change the doctest. I think this is a bad change in Symbolics:
Hyperplane(x - y == 2) should not translate to Hyperplane{Float64, Vector{Float64}}([-1.0, 1.0], 2.0).
I see two options:

  1. Check whether we can change the translation in LazySets.
  2. Restrict the Symbolics version to pre-v5.31.0.

EDIT: I asked in Symbolics#1182. They will add an argument for sorting to the function get_variables.

@schillic schillic added the discussion 🗣️ Requires human input label Jun 26, 2024
@schillic schillic marked this pull request as ready for review June 26, 2024 20:48
@schillic schillic added the invalid 🚫 This doesn't seem right label Jun 27, 2024
This was referenced Jun 27, 2024
@schillic schillic removed the discussion 🗣️ Requires human input label Jun 28, 2024
@schillic schillic deleted the schillic/fix branch June 28, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid 🚫 This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant