Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#46 - Fix piracy with contains #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#46 - Fix piracy with contains #50

wants to merge 2 commits into from

Conversation

schillic
Copy link
Member

@schillic schillic commented Mar 1, 2024 •
edited
Loading

Closes #46.

  1. commit: After thinking about it for a while, I originally suggested to simply remove the function. It is not a common use case and also very easy to define manually.
  2. commit: The function names were a bit inconsistent. Now I suggest to rename them instead, and with a new name we can keep the old function.

@schillic schillic marked this pull request as ready for review March 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix piracy with contains
1 participant
@schillic