Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguities #801

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Fix ambiguities #801

merged 2 commits into from
Apr 5, 2024

Conversation

schillic
Copy link
Member

@schillic schillic commented Mar 10, 2024

See #788. Four ambiguities remain.

EDIT: The first commits have been outsourced to #811 and merged. This branch is now rebased.
The first commit makes changes that should be clear.
The other commits change/remove behaviors. But I would argue that we do not need these anymore now that unions are LazySets, and some methods have been questionable.

@schillic schillic marked this pull request as ready for review March 10, 2024 21:34
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but for the removals, i suggest that we check whether such methods still work by making use of their corresponding LazySets methods.

i made a task > #810

src/Flowpipes/setops.jl Show resolved Hide resolved
@schillic schillic mentioned this pull request Mar 16, 2024
@schillic schillic merged commit 1f3db0f into master Apr 5, 2024
6 checks passed
@schillic schillic deleted the schillic/788 branch April 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants