-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry consistency tests: For every version, check that each (weak)compat entry has a corresponding (weak)deps entry #525
base: master
Are you sure you want to change the base?
Conversation
8d731a8
to
31e9292
Compare
… entry has a corresponding deps entry
…ve `julia` listed in Deps.toml.
7d83570
to
fcd704e
Compare
# Note: it is legal for a package to have Compat.toml but not have | ||
# Deps.toml. Specifically, this is legal if (and only if) the package | ||
# does not have any dependencies, and does have a compat entry for `julia`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't WeakDeps.toml be part of this reasoning too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should do the same thing for WeakDeps/WeakCompat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. We now do this for both Deps/Compat and also for WeakDeps/WeakCompat.
For Deps/Compat, it is legal for Compat.toml to exist but Deps.toml to not exist - specifically, if a package has no dependencies, and it has a compat entry for julia
, then it will have Compat.toml but not Deps.toml.
However, if I understand correctly, it is never legal for a package to have Compat.toml but not have Deps.toml.
Fixes #522