Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: Allow bucket names ending with -s3alias / starting with xn-- #51

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Experiment: Allow bucket names ending with -s3alias / starting with xn-- #51

merged 2 commits into from
Jul 16, 2024

Conversation

Drvi
Copy link
Member

@Drvi Drvi commented Jul 16, 2024 •
edited
Loading

Apparently, these are illegal in the name of buckets created by the user but are valid for AWS to create.

@Drvi Drvi changed the title Experiment: Allow bucket names ending with -s3alias Experiment: Allow bucket names ending with -s3alias / starting with xn-- Jul 16, 2024
@Drvi
Copy link
Member Author

Drvi commented Jul 16, 2024

Not sure whats up with CI, locally tests are green

geokollias
geokollias approved these changes Jul 16, 2024
View reviewed changes
Copy link

@geokollias geokollias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we want to keep these checks for bucket creation only for some reason (though, as discussed, I'd expect aws to fail the creation request in this case) - otherwise looks good, thanks!

@Drvi Drvi enabled auto-merge (squash) July 16, 2024 10:37
@Drvi Drvi disabled auto-merge July 16, 2024 10:37
@Drvi Drvi merged commit 9ffe097 into main Jul 16, 2024
2 of 5 checks passed
@Drvi Drvi deleted the td-allow-s3alias branch July 16, 2024 10:38
@Drvi Drvi restored the td-allow-s3alias branch July 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geokollias geokollias geokollias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drvi @geokollias