Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tikz figure export #105

Merged
merged 16 commits into from
Nov 2, 2023
Merged

Tikz figure export #105

merged 16 commits into from
Nov 2, 2023

Conversation

d-monnet
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/BenchmarkProfiles.jl 100.00% <ø> (ø)
src/performance_profiles.jl 91.48% <100.00%> (+1.24%) ⬆️
src/tikz_export.jl 95.65% <95.65%> (ø)

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

tmigot
tmigot requested changes Oct 29, 2023
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks overall good for me, just a couple of comments.

There was also @dpo comment #104 (comment)

src/tikz_export.jl Outdated Show resolved Hide resolved
src/tikz_export.jl Outdated Show resolved Hide resolved
src/tikz_export.jl Outdated Show resolved Hide resolved
src/tikz_export.jl Outdated Show resolved Hide resolved
src/tikz_export.jl Outdated Show resolved Hide resolved
src/performance_profiles.jl Outdated Show resolved Hide resolved
src/performance_profiles.jl Outdated Show resolved Hide resolved
src/tikz_export.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

@dpo
Copy link
Member

dpo commented Oct 30, 2023

Have you seen https://github.com/JuliaTeX/TikzPictures.jl ? It also allows exporting the TikZ to PDF, SVG, etc.

@d-monnet
Copy link
Contributor Author

Have you seen https://github.com/JuliaTeX/TikzPictures.jl ? It also allows exporting the TikZ to PDF, SVG, etc.

Yes, I've just tried it and it works great ! I'll add different export options to this PR based on that library.

@d-monnet
add figure export options provided by TizkPictures.jl
4a36c94 
export options are .tikz, .tex, .svg and .pdf
@d-monnet
Copy link
Contributor Author

Last commit implements TikzPictures.jl interface to export in different formats. If you have spare time you can generate a few .pdf and suggest improvements/ additional features.

@github-actions
Copy link
Contributor

Package name latest stable
SolverBenchmark.jl

tmigot
tmigot requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @d-monnet for the changes. I have a couple more comments.

After this PR, I would suggest to open a few issues for developing this:

  • add this new feature in the package documentation
  • use Requires.jl or similar to add TikzPictures.jl as an optional dep.

Surely, this will be improved as we get more practical cases.

src/performance_profiles.jl Outdated Show resolved Hide resolved
src/tikz_export.jl Outdated Show resolved Hide resolved
Project.toml Show resolved Hide resolved
@d-monnet
Copy link
Contributor Author

d-monnet commented Nov 1, 2023

Thanks @d-monnet for the changes. I have a couple more comments.

After this PR, I would suggest to open a few issues for developing this:

* add this new feature in the package documentation

* use Requires.jl or similar to add TikzPictures.jl as an optional dep.

Surely, this will be improved as we get more practical cases.

Sure, I'll open the issues once you confirm that the PR can be merged.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Package name latest stable
SolverBenchmark.jl

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Package name latest stable
SolverBenchmark.jl

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Package name latest stable
SolverBenchmark.jl

tmigot
tmigot approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@d-monnet
Copy link
Contributor Author

d-monnet commented Nov 2, 2023

LGTM, thanks!

Thanks for the review @tmigot !

@d-monnet d-monnet merged commit f10841d into JuliaSmoothOptimizers:main Nov 2, 2023
17 of 18 checks passed
@d-monnet d-monnet deleted the tikz-figure-export branch November 2, 2023 18:45
@d-monnet d-monnet mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigot tmigot tmigot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-monnet @dpo @tmigot