fix: discrepancy in problem names.

[danphenderson]

Reference #356

Q: How should I handle the NLS name declared here:

OptimizationProblems.jl/src/ADNLPProblems/errinros_mod.jl

Line 40 in 59bf416

return ADNLPModels.ADNLSModel!(F!, x0, 2 * (n - 1), name = "errinros-nls"; kwargs...)

should it be errinros_mod_nls or errinros-mod-nls or errinros_mod-nls?

[tmigot]

It should be -nls

Thanks!

[tmigot]

So, the tests do not pass because of rosenbrock that we define via genrose here https://github.com/JuliaSmoothOptimizers/OptimizationProblems.jl/blob/main/src%2FADNLPProblems%2Fgenrose.jl

Could you modify it, so that

rosenbrock(args...; kwargs...) = genrose(args..., n = 2; delete!(Dict(kwargs), :n)...)

becomes

rosenbrock(args...; kwargs...) = genrose(args..., n = 2, name="rosenbrock"; delete!(Dict(kwargs), :n)...)

[tmigot]

LGTM, thanks!