Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile the objective #639
Profile the objective #639
Changes from 59 commits
7eb5f7a
223836b
c6dbfd2
d701e67
432f352
a82277d
d3d9c72
f6a970a
799999e
9bdac8e
74c4706
7e19d32
fc082a6
39c3a3b
78b0f36
48920d5
c9406a2
49a39b8
9c29952
beb7264
030d5b7
44fa4a7
428fa73
8d43e07
927a805
a156265
1469cd9
1027373
75cfed1
608d4a4
3cc7b53
16dc0b3
0c7c65b
4221eeb
f81f44c
bb5dc6b
d7d314f
f7ac63e
7ab2697
5f7d60c
8bf48e9
d192ba0
3f05c8a
d063859
cd30dd4
c1e78aa
deae52c
a628555
f26a825
b9ffc30
29be05e
1ac38be
d0be208
3a7e616
2bee46d
fd80166
a9d7068
f32cda2
dc5de78
688833b
6aace76
48e04d6
17008ff
951adfc
15bd235
8a4ab2c
9918f92
0df4893
06498ad
1cfb445
fa241f4
bba580e
c16e674
182d24f
45fd0b7
1d664c5
33b20b5
a535e1f
5ee3f72
2f54b68
c89480c
9f2ec89
9d85ca4
4f55a4f
afa4827
622c9ed
69e6286
a938c5a
0c3904b
c65c61d
16447b7
c064f74
a7926e2
3a6baeb
c381204
40006af
1821e42
b35fdef
f031a03
48dee3e
664b033
2c1be4c
f8f4559
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens in rank deficiency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Part of me just wants to tell users to ensure that their model matrices have full rank but that might be an unpopular suggestion. I'll have to look up what happens with the
stderror
property in that case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not adverse to adding a
!!! warning
entry to the docstring about rank deficiency and we can follow up on this when we have time / energy / necessity.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DictTable
is technically a column table, so this is nonbreaking, but it's good to highlight the actual guarantee.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you edit the suggestion to replace "Table.jl" with "Tables.jl" and, in the note, replace "only that there the" with "only that the"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmbates done