Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for #177 #118

Closed
wants to merge 3 commits into from
Closed

Hotfix for #177 #118

wants to merge 3 commits into from

Conversation

torfjelde
Copy link

@torfjelde torfjelde commented Mar 6, 2021

Fix for #117 thanks to @devmotion

Seems like it would be a good idea to get this in ASAP and then change back when FileIO.jl has been fixed.

fix for #/117
@devmotion
Copy link
Member

This PR only raises the lower bound for FileIO, so I don't think it fixes the problem? Depending on the Pkg resolver, users might not even benefit from an upper bound - the new version of RDatasets might not be installed automatically since it would involve downgrading some other packages (such as FileIO).

@torfjelde
Copy link
Author

Wait, doesn't 1.5 mean only 1.5.x is allowed?

@devmotion
Copy link
Member

No, it means [1.5.0, 2.0.0): https://julialang.github.io/Pkg.jl/v1/compatibility/#Caret-specifiers

@torfjelde
Copy link
Author

Hah, yeah I just checked; it's been too long since I've touched [compat].

Project.toml Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 6, 2021

Codecov Report

Merging #118 (8c813df) into master (c2b17d0) will decrease coverage by 2.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   84.00%   81.81%   -2.19%     
==========================================
  Files           4        4              
  Lines          25       22       -3     
==========================================
- Hits           21       18       -3     
  Misses          4        4              
Impacted Files Coverage Δ
src/datasets.jl 57.14% <0.00%> (-5.36%) ⬇️
src/dataset.jl 90.00% <0.00%> (-0.91%) ⬇️
src/packages.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b17d0...8c813df. Read the comment docs.

@devmotion
Copy link
Member

Could we check (or does anyone know) if Pkg would install such a hotfix when running ] up?

Co-authored-by: David Widmann <[email protected]>
@devmotion
Copy link
Member

I close this PR since the issue is fixed upstream. Maybe #119 could still be useful but that's a separate issue.

@devmotion devmotion closed this Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants