Test earliest supported Julia version and prereleases #178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 96.63% 96.65% +0.01%
==========================================
Files 2 2
Lines 446 448 +2
==========================================
+ Hits 431 433 +2
Misses 15 15 ☔ View full report in Codecov by Sentry. |
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| version: | ||
| - '1' # automatically expands to the latest stable 1.x release of Julia | ||
| - 'lts' | ||
| - 'min' # earliest supported version of Julia |
There was a problem hiding this comment.
I'm wondering if min is necessary given that this is a stdlib
There was a problem hiding this comment.
Hmm maybe not. I added it since Statistics specifies a julia = "1.9.4" compat.
|
If you don't mention arch, does it just pick aarch64 for mac and x64 for all the others? Just should make sure that we are not doing x64 in emulation on macOS-latest, and we are indeed running natively. Otherwise, I don't have a strong preference. We can always add |
Yes, by default the setup-julia action uses the Julia binaries for the architecture of the runner, ie aarch64 on macOS-latest. This can be seen in e.g. https://github.com/JuliaStats/Statistics.jl/actions/runs/11428315624/job/31793421540?pr=178#step:3:8 |
|
Hmm, I might have hit merge a bit early. |
#167 removed tests on nightly and added the
include-prereleasesoption. However, I think it would be better to testpreinstead of setting this option: Otherwise, once a pre-release of Julia v1 is available, tests with1will only test the pre-release but the latest stable build will not be tested anymore.Additionally, I think it would be good to test
min, the earliest supported Julia version, as well to avoid accidentally breaking support for old Julia versions.