Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds formatting workflow #530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ValentinKaisermayer
Copy link
Contributor

No description provided.

@ValentinKaisermayer
Copy link
Contributor Author

cc @iblislin

@ValentinKaisermayer
Copy link
Contributor Author

There are many possibilities here.

This creates a PR with the formatted code.
Another possibility would be to check if the code in the PR is formatted. This would have the benefit that the history is cleaner and blame would show the author and not the formatting PR.

@iblislin
Copy link
Collaborator

ah, I will vote for the later option.

@ValentinKaisermayer
Copy link
Contributor Author

Formatting check failed as expected.

@ValentinKaisermayer
Copy link
Contributor Author

I have no idea why the check still fails. If formatted the files locally and pushed them.

julia> format(".")
true

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.04453% with 32 lines in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (3291223) to head (75d2263).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/plotrecipes.jl 21.05% 15 Missing ⚠️
src/apply.jl 91.83% 4 Missing ⚠️
src/tables.jl 80.95% 4 Missing ⚠️
src/timearray.jl 93.87% 3 Missing ⚠️
src/utilities.jl 86.95% 3 Missing ⚠️
src/basemisc.jl 0.00% 1 Missing ⚠️
src/broadcast.jl 90.90% 1 Missing ⚠️
src/split.jl 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   85.44%   84.83%   -0.61%     
==========================================
  Files          11       11              
  Lines         625      712      +87     
==========================================
+ Hits          534      604      +70     
- Misses         91      108      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants