Adds method for splitting data into periods #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblislin
reviewed
Jul 23, 2024
src/split.jl
Outdated
| - `period::Function`: Function, e.g. `Dates.day` that is used to split the `data`. | ||
| """ | ||
| split(data::TimeSeries.TimeArray, period::Function) = map(i -> data[i], _split(data, period)) | ||
| function _split(data::TimeSeries.TimeArray, period::Function) |
There was a problem hiding this comment.
well, I'm think about : does return an iterator better than just an Array?
There was a problem hiding this comment.
I now return an Iterators.map
Open
iblislin
reviewed
Dec 16, 2024
iblislin
reviewed
Dec 16, 2024
| @testset "split" begin | ||
|
|
||
|
|
||
| @testset "find methods" begin |
There was a problem hiding this comment.
well, could you send the formatting patch as another PR?
(and maybe introduce some formatter in the standalone PR, e.g. https://github.com/julia-actions/julia-format)
This cause the patch not human readable.
Co-authored-by: Iblis Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.