Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add work around for SIP restrictions on macOS #45

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

giordano
Copy link
Member

@giordano giordano commented Feb 16, 2023

This requires JuliaPackaging/Yggdrasil#4987. I verified that without that PR, the new test fails, but with the PR they're successful.

CC @ericphanson @GunnarFarneback @staticfloat @mortenpi.

Fix #40.

@ericphanson
Copy link
Contributor

Awesome!!

@giordano
Copy link
Member Author

@ericphanson @GunnarFarneback @mortenpi After JuliaPackaging/Yggdrasil#4987 makes it to the registry (in ~20 minutes or so), can you please try out this PR on your macOS systems? I successfully ran the test on macOS and Linux (of course on Linux it was working also before this PR, but good to test anyway).

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 100.00% // Head: 95.23% // Decreases project coverage by -4.77% ⚠️

Coverage data is based on head (3f4de18) compared to base (a7fd3e9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #45      +/-   ##
===========================================
- Coverage   100.00%   95.23%   -4.77%     
===========================================
  Files            1        2       +1     
  Lines           19       21       +2     
===========================================
+ Hits            19       20       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/git_function.jl 95.00% <0.00%> (-5.00%) ⬇️
src/Git.jl 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@giordano
Copy link
Member Author

At least tests are passing on all platforms on CI 🙂

@giordano
Copy link
Member Author

Codecov is a required CI job, but it's failing because code coverage is apparently broken on the @static line.....

@DilumAluthge
Copy link
Member

I removed Codecov from required. Is there an open Julia issue to track the issue of @static not being having correct code coverage reported?

@mortenpi
Copy link

This is awesome, the Documenter macOS tests pass as well with this!

@GunnarFarneback
Copy link
Contributor

Confirmed that pointing GunnarFarneback/LocalRegistry.jl#38 to this branch passes all tests.

@giordano
Copy link
Member Author

Is there an open Julia issue to track the issue of @static not being having correct code coverage reported?

I don't know, but I wonder if it's a problem with nested @static? Because the outer one is detected correctly, and this one is definitely stepped over, otherwise the new test wouldn't work on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble with auth on macOS due to SIP
6 participants