-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add work around for SIP restrictions on macOS #45
Conversation
Awesome!! |
@ericphanson @GunnarFarneback @mortenpi After JuliaPackaging/Yggdrasil#4987 makes it to the registry (in ~20 minutes or so), can you please try out this PR on your macOS systems? I successfully ran the test on macOS and Linux (of course on Linux it was working also before this PR, but good to test anyway). |
Codecov ReportBase: 100.00% // Head: 95.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
===========================================
- Coverage 100.00% 95.23% -4.77%
===========================================
Files 1 2 +1
Lines 19 21 +2
===========================================
+ Hits 19 20 +1
- Misses 0 1 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
At least tests are passing on all platforms on CI 🙂 |
Codecov is a required CI job, but it's failing because code coverage is apparently broken on the |
I removed Codecov from required. Is there an open Julia issue to track the issue of |
This is awesome, the Documenter macOS tests pass as well with this! |
Confirmed that pointing GunnarFarneback/LocalRegistry.jl#38 to this branch passes all tests. |
I don't know, but I wonder if it's a problem with nested |
This requires JuliaPackaging/Yggdrasil#4987. I verified that without that PR, the new test fails, but with the PR they're successful.
CC @ericphanson @GunnarFarneback @staticfloat @mortenpi.
Fix #40.