Code cleanup. Deleted unnecessary arguments #17
Conversation
|
Just some code cleanup, I would also like to add support for the dash delimiters and user delimiters. Working on it |
|
Hi, thanks so much. Definitely would love some help on the delimiter side -- very keen to hear what you have in mind. On this change specifically though, less sure I see the benefit. The original code here had no conditionals, whereas the new code has quite a few (or really branches). Which in general I think is the reverse direction from what I'd want. Happy to hear thoughts of course. |
|
I see your point. For me it was clearer to read like this. Regarding the --, I still didn't find the time. I wish I had it a few times during the week though hahaha so it might worth putting the effort. I'll let you know if I achieve any progress on this. |
|
No worries. Going to close this PR specifically then, but your thoughts or contribution on #7 would be awesome! |
No description provided.