fix: Make adjacent nodes in hex have dist 1 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the nodes were separated in the y axis by 1, which results in adjacent nodes forming isosceles triangles instead of equilaterals. Scaling the nodes vertically to shrink the distance between nodes results in adjacent nodes having distance one. This commit contains one failing test for the purpose of demonstrating the requirement for re-initialisation.
|
Discussed briefly in #173 |
|
great job! No changes are required and I'll be merging this next week. Sticking this image here for reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the nodes were separated in the y axis by 1, which results in adjacent nodes forming isosceles triangles instead of equilaterals. Scaling the nodes vertically to shrink the distance between nodes results in adjacent nodes having distance one. This commit contains one failing test for the purpose of demonstrating the requirement for re-initialisation.