-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HtmlAgilityPack, Pester Tests, refactor #11
Conversation
Hey @JustinGrote, any thoughts on to approve this PR and update the PS Gallery version? |
Thanks for the follow up! It just fell off my radar. I am in London this week but can hopefully look into it next week. |
i honestly forgot about this one as well, it started because this was bugging me.. pwsh -nop -c 'Import-Module PowerHTML;Get-Error | % InvocationInfo | Select-Object MyCommand, Line'
MyCommand Line
--------- ----
Get-ChildItem $ModuleSettings = @( Get-ChildItem -Path $PSScriptRoot\Settings\*.json -ErrorAction SilentlyContinue )… and kind of snowballed into this 😄 couple of thoughts,
i can update the pr if you like these changes. oh and also let me know if theres anything you want me to change in the pr. |
Thanks for your patience, this has been merged and released as |
changes
ConvertFrom-Html
this would also simplify if you wanted to add a param for special cases like, in #7