Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HtmlAgilityPack, Pester Tests, refactor #11

Merged
merged 11 commits into from
May 22, 2024

Conversation

trackd
Copy link
Contributor

@trackd trackd commented Mar 29, 2024

changes

this would also simplify if you wanted to add a param for special cases like, in #7

$html = [HtmlAgilityPack.HtmlDocument]@{
	OptionOutputAsXml           = $true
	OptionReadEncoding          = $true
	OptionDefaultStreamEncoding = [System.Text.Encoding]::UTF8
	OptionAutoCloseOnEnd        = $true
	OptionFixNestedTags         = $true
}
$web = [HtmlAgilityPack.HtmlWeb]@{
	AutoDetectEncoding = $false
	OverrideEncoding   = [System.Text.Encoding]::UTF8
}

@gummigroda
Copy link

Hey @JustinGrote, any thoughts on to approve this PR and update the PS Gallery version?

@JustinGrote
Copy link
Owner

Thanks for the follow up! It just fell off my radar. I am in London this week but can hopefully look into it next week.

@JustinGrote JustinGrote self-assigned this May 8, 2024
@JustinGrote JustinGrote self-requested a review May 8, 2024 14:17
@JustinGrote JustinGrote added the enhancement New feature or request label May 8, 2024
@trackd
Copy link
Contributor Author

trackd commented May 12, 2024

i honestly forgot about this one as well, it started because this was bugging me..

pwsh -nop -c 'Import-Module PowerHTML;Get-Error | % InvocationInfo | Select-Object MyCommand, Line'
MyCommand     Line
---------     ----
Get-ChildItem $ModuleSettings = @( Get-ChildItem -Path $PSScriptRoot\Settings\*.json -ErrorAction SilentlyContinue )…

and kind of snowballed into this 😄

couple of thoughts,

  • support for net40-client (ie PS 4)? could probably stick to netstandard2.0
  • move lib loading to RequiredAssemblies
  • remove the settings and private loading from the psm1, theres nothing there..

i can update the pr if you like these changes.

oh and also let me know if theres anything you want me to change in the pr.

@JustinGrote JustinGrote merged commit 418d00a into JustinGrote:master May 22, 2024
@JustinGrote
Copy link
Owner

Thanks for your patience, this has been merged and released as 0.2.0, please test and let me know if there are any regressions.

@trackd trackd deleted the update branch May 22, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest version of the HtmlAgilityPack v1.11.46
3 participants