-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for AWS SecretManager #13
base: master
Are you sure you want to change the base?
Conversation
e3262bc
to
e981b29
Compare
Hi @JustinPihony! Any chance to merge and release this one any time soon? |
Hi @musketyr I will review this and release tomorrow if all looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to finish wrapping my head around this - as I think the Extension can be rewritten to use most of what is already there. But I wanted to ping you early that you need to add to /deploy/jp.classmethod.aws.reboot.gradle if you want it to be it's own plugin, which is how you have the README set up
AWSSecretsManagerClientBuilder builder = AWSSecretsManagerClient.builder(); | ||
|
||
AwsPluginExtension aws = getProject().getExtensions().getByType(AwsPluginExtension.class); | ||
String profile = aws.getProfileName() == null ? System.getenv("AWS_PROFILE") : aws.getProfileName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be added to the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure where should I put it
@JustinPihony thanks for the review! I've added the plugin into the deploy script but I'm still bit lost with your previous comment above. |
Hi @JustinPihony any way how to move this PR forward? |
This PR adds a support for AWS SecretManager. This can be used to easily distribute secrets for the developers.
Example:
The
destination
file is marked as output so it's only downloaded when missing