Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signal tests #11

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix signal tests #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions tests/auto/utils/signal/tst_signal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ TEST_SUITE("Signal")
{
int val = 4;

auto *appInstance = new KDFoundation::CoreApplication;
KDFoundation::CoreApplication app;
KDBindings::Signal<int> signal1;
KDBindings::Signal<int> signal2;

std::thread thread1([&] {
signal1.connectDeferred(appInstance->connectionEvaluator(), [&val](int value) {
signal1.connectDeferred(app.connectionEvaluator(), [&val](int value) {
val += value;
});
});

std::thread thread2([&] {
signal2.connectDeferred(appInstance->connectionEvaluator(), [&val](int value) {
signal2.connectDeferred(app.connectionEvaluator(), [&val](int value) {
val += value;
});
});
Expand All @@ -38,25 +38,25 @@ TEST_SUITE("Signal")
signal2.emit(3);
CHECK(val == 4); // val not changing immediately after emit

appInstance->connectionEvaluator()->evaluateDeferredConnections();
app.connectionEvaluator()->evaluateDeferredConnections();

CHECK(val == 9);
}

TEST_CASE("Emit Multiple Signals with Evaluator")
{
auto *appInstance = new KDFoundation::CoreApplication;
KDFoundation::CoreApplication app;
KDBindings::Signal<int> signal1;
KDBindings::Signal<int> signal2;

int val1 = 4;
int val2 = 4;

signal1.connectDeferred(appInstance->connectionEvaluator(), [&val1](int value) {
signal1.connectDeferred(app.connectionEvaluator(), [&val1](int value) {
val1 += value;
});

signal2.connectDeferred(appInstance->connectionEvaluator(), [&val2](int value) {
signal2.connectDeferred(app.connectionEvaluator(), [&val2](int value) {
val2 += value;
});

Expand All @@ -74,19 +74,19 @@ TEST_SUITE("Signal")
CHECK(val1 == 4);
CHECK(val2 == 4);

appInstance->connectionEvaluator()->evaluateDeferredConnections();
app.connectionEvaluator()->evaluateDeferredConnections();

CHECK(val1 == 6);
CHECK(val2 == 7);
}

TEST_CASE("Connect, Emit, Disconnect, and Evaluate")
{
auto *appInstance = new KDFoundation::CoreApplication;
KDFoundation::CoreApplication app;
KDBindings::Signal<int> signal;
int val = 4;

auto connection = signal.connectDeferred(appInstance->connectionEvaluator(), [&val](int value) {
auto connection = signal.connectDeferred(app.connectionEvaluator(), [&val](int value) {
val += value;
});

Expand All @@ -97,7 +97,7 @@ TEST_SUITE("Signal")

connection.disconnect();

appInstance->connectionEvaluator()->evaluateDeferredConnections();
app.connectionEvaluator()->evaluateDeferredConnections();

CHECK(val == 4);
}
Expand Down