Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enable cached builds #2

Merged
merged 7 commits into from
Jun 10, 2024
Merged

CI: Enable cached builds #2

merged 7 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. ci: Output build artifacts

    @LeonMatthesKDAB
    LeonMatthesKDAB committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    71f0004 View commit details
    Browse the repository at this point in the history

  2. ci: Add sccache 

    We use the embedded debug information for MSVC, because we ran into this error message in our windows CI:
```
FAILED: 3rdparty/fmt/CMakeFiles/fmt.dir/src/os.cc.obj
sccache C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1440~1.338\bin\Hostx64\x64\cl.exe  /nologo /TP -DKNUT_BUILDDATE=\"2024-06-07\" -DKNUT_VERSION=\"1.0\" -DKNUT_VERSION_STRING="\"1.0 (revision: c91adac)\"" -DTEST_DATA_PATH=\"D:/a/knut/knut/test_data\" -ID:\a\knut\knut\build-ci\3rdparty\fmt -ID:\a\knut\knut\3rdparty\fmt -ID:\a\knut\knut\build-ci\3rdparty\fmt\fmt_autogen\include -ID:\a\knut\knut\3rdparty\fmt\include /DWIN32 /D_WINDOWS /GR /EHsc /Zi /O2 /Ob1 /DNDEBUG -std:c++latest -MD /showIncludes /Fo3rdparty\fmt\CMakeFiles\fmt.dir\src\os.cc.obj /Fdfmt.pdb /FS -c D:\a\knut\knut\3rdparty\fmt\src\os.cc
D:\a\knut\knut\3rdparty\fmt\src\os.cc: fatal error C1041: cannot open program database 'D:\a\knut\knut\build-ci\fmt.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS
```
Obviously /FS won't help, as that's already added.

However, in this issue: https://gitlab.kitware.com/cmake/cmake/-/issues/20222,
@mwestphal suggests that /Zi may be the issue. This makes sense, as
that's what's forcing the use of a separate pdb file for debug info.

If we use the Embedded format, this should fall back to /Z7, which
includes the debug information within the object files themselves.
So there should be no pdb file that can have lock contention.
    @LeonMatthesKDAB
    LeonMatthesKDAB committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    292f89f View commit details
    Browse the repository at this point in the history

  3. ci: Add step to inspect environment variables

    @LeonMatthesKDAB
    LeonMatthesKDAB committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4d065a0 View commit details
    Browse the repository at this point in the history

  4. ci: Only upload artifacts, if the build is failing

    @LeonMatthesKDAB
    LeonMatthesKDAB committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    6d49d30 View commit details
    Browse the repository at this point in the history

  5. ci: Use a custom caching strategy for sccache 

    We can adopt the strategy from CXX-Qt, which is working well.
Hopefully now we get fully cached builds.
    @LeonMatthesKDAB
    LeonMatthesKDAB committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    7edfbf7 View commit details
    Browse the repository at this point in the history

  6. ci: Add a cpp file for version information 

    This should allow us to update the version information on each commit, but
still cache most of the build.
The single compilation unit for version.cpp won't be cached, but
everything else can be cached, as the compiler arguments won't change on
every commit.
    @LeonMatthesKDAB
    LeonMatthesKDAB committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3c6e34b View commit details
    Browse the repository at this point in the history

  7. ci: Only update caches from main repository 

    Forks are not allowed to update the cache
    @LeonMatthesKDAB
    LeonMatthesKDAB committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    02161c3 View commit details
    Browse the repository at this point in the history